Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close subscription resource release #592

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Apr 6, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@xdlbdy xdlbdy requested a review from ifplusor April 6, 2023 02:22
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #592 (0f9c99d) into main (ee76217) will decrease coverage by 2.35%.
The diff coverage is 46.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   57.07%   54.72%   -2.35%     
==========================================
  Files         190      211      +21     
  Lines       15191    16929    +1738     
==========================================
+ Hits         8670     9265     +595     
- Misses       5884     6965    +1081     
- Partials      637      699      +62     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <ø> (ø)
internal/gateway/proxy/direct.go 15.84% <ø> (-57.50%) ⬇️
internal/gateway/proxy/proxy.go 23.23% <ø> (+0.14%) ⬆️
internal/gateway/proxy/reigister.go 100.00% <ø> (ø)
internal/gateway/proxy/util.go 0.00% <ø> (ø)
...nternal/primitive/authentication/authentication.go 34.09% <ø> (ø)
internal/primitive/authentication/client.go 0.00% <ø> (ø)
internal/primitive/authorization/action.go 0.00% <ø> (ø)
... and 71 more

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f90ea26...0f9c99d. Read the comment docs.

@ifplusor ifplusor added the co/trigger relating to trigger label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/trigger relating to trigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants